[skip changelog] Libraries install dir path is now canonical #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stems mainly from the fact the CI uses 8.3 naming convention for paths on Windows, that causes several issues when trying to verify that certain paths are printed in the output of certain commands. Making sure that canonical paths are set as installation directory for all libraries makes it easier to test. For more info on 8.3 paths see: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#short-vs-long-names
silvanocerza
added
topic: testing
os: windows
cmaglie
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixes issues with testing on Windows.
The Workflow runners use 8.3 style naming convention for paths on Windows, see an example below.
Libraries install directory path is saved using the 8.3 style, this causes problems when trying to verify that a certain path is returned in the output of certain commands on Windows.
All libraries install directory paths are canonicalized so the 8.3 style path is not printed on Windows.
titled accordingly?
No.
We'll need to rebase #1291 after this is merged.
See how to contribute